So for the past 45 minutes (probably 2 hours) or so, I decided to do a little digging.
I recently had another visit from the PPU with a different officer this time. I spoke more about colleges and wanting to apply for courses, which I was told if I do end up applying, she would disclose to the college even though by my understanding, my conviction should be considered spent and would breach the Rehabilitation of Offenders Act 1974 if she did with out my consent. But is the conviction really considered spent?

With the help of the fancy new AI going around I started asking some questions, based on my findings the answer is no. Remaining on the SOR is still considered a legal requirement of the conviction, while this remains I have not yet completed the rehabilitation period.
I could have sworn when doing my research while applying to discharge my SHPO, that when the SHPO ends. Even while remaining on the SOR the conviction would be considered spent? My barrister even told me this would be the case when I asked.
Unless I have some how woken up to an alternate universe where this is not true, got my wires mixed up and misunderstood the Rehabilitation of Offenders Act 1974 or has something been changed?

The main point of me fighting to have my SHPO discharged was so I could apply with out being pressured to disclose the conviction, was I wrong this whole time?